Introduce pg pool options #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-iohk
requested review from
harrysolovay,
joaosreis and
johnmarcou
as code owners
piotr-iohk
commented
Nov 6, 2024
src/config.rs
Outdated
|
|
||
| /// The maximum number of concurrent connections allowed in the Archive | ||
| /// Database connection pool. | ||
| #[arg(long, env = "MINAMESH_MAX_DB_POOL_SIZE", default_value_t = 10)] |
There was a problem hiding this comment.
Actually there is similar env var in rosetta MINA_ROSETTA_MAX_DB_POOL_SIZE: https://github.com/MinaProtocol/mina/blob/ca9c8c86aa21d3c346d28ea0be7ad4cb0c22bf7f/src/app/rosetta/lib/rosetta.ml#L192-L197
so maybe we should give it 128 as default? 🤔
There was a problem hiding this comment.
Whatever you think is best. This PR looks good. Approving incase you'd prefer to merge as is.
There was a problem hiding this comment.
Let's go with 128.
harrysolovay
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing search-tx optimizations I've noticed that performance deteriorates suddenly after a few requests and it remains deteriorated until the mina-mesh restart.
After some research and playing around I've found that that when we use:
There are some defaults, in particular
idle_timeout: 600s-> https://github.com/launchbadge/sqlx/blob/main/sqlx-core/src/pool/options.rs#L161. Which causes that after we reach the max pool size (default:10) they become stale for 600s and not quite re-used and that seems to affect the performance.So this PR makes both variables (pool_size and idle_timeout) configurable via env vars, giving some reasonable defaults (pool_size=10 and idle_timeout=1). In particular low idle timeout seems to address the issue of deteriorating performance as the unused pools are probably garbage collected.