Allow updating the verification key (requiring a signature from the admin) #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR does two things: - it adds a method `canChangeVerificationKey` to the admin contract, to check permissions for changing the verification key. This method is called from `updateVerificationKey` in the token contract. - The deploy arguments for the token contract now have a new field, `allowUpdates`. If that is set to `true`, updates of the verification key will be allowed also during the current protocol version. This allows updating the token contract, for example when there is a new version of o1js.
mitschabaude
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, the token contract could only be updated after an incompatible change of the protocol. This reduces the amount of trust in the deployer, but it did not allow updating the contract in order to be compatible with new versions of o1js.
We're changing the default behaviour to allow updates of the verification key, as long as the admin contract grants permission (which in the default admin contract will be granted if the transaction has been signed by the admin key).