Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs fixes #115

Merged
merged 4 commits into from
Jan 3, 2025
Merged

Docs fixes #115

merged 4 commits into from
Jan 3, 2025

Conversation

egeaybars123
Copy link
Contributor

1-) The hyperlink for the "MIP-4" in the introduction is not found, so I updated it to the latest link of the MIP-4.
2-) In the token escrow contract, when I copied and pasted the code, it did not compile because of the fact that "async" keyword was not written for the functions. Also, in order to make the job of the developers easier, I added imports for the script (assuming that the developer installed the mina-fungible-token via npm).

Copy link
Collaborator

@kantp kantp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! If you can add back the reference to the right section as per the suggestion, I'll happily merge this!

documentation/introduction.md Outdated Show resolved Hide resolved
@egeaybars123
Copy link
Contributor Author

egeaybars123 commented Jan 3, 2025

Committed the suggested changes. Thank you! @kantp

@kantp
Copy link
Collaborator

kantp commented Jan 3, 2025

Awesome, thanks @egeaybars123!

@kantp kantp enabled auto-merge January 3, 2025 12:38
@kantp kantp added this pull request to the merge queue Jan 3, 2025
Merged via the queue into MinaFoundation:main with commit 8dbf75a Jan 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants