-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs fixes #115
Merged
Merged
Docs fixes #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egeaybars123
requested review from
mitschabaude,
kantp and
ymekuria
as code owners
December 28, 2024 19:51
kantp
reviewed
Jan 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this! If you can add back the reference to the right section as per the suggestion, I'll happily merge this!
Co-authored-by: Philipp Kant <[email protected]>
Committed the suggested changes. Thank you! @kantp |
Awesome, thanks @egeaybars123! |
kantp
approved these changes
Jan 3, 2025
kantp
reviewed
Jan 3, 2025
kantp
reviewed
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1-) The hyperlink for the "MIP-4" in the introduction is not found, so I updated it to the latest link of the MIP-4.
2-) In the token escrow contract, when I copied and pasted the code, it did not compile because of the fact that "async" keyword was not written for the functions. Also, in order to make the job of the developers easier, I added imports for the script (assuming that the developer installed the mina-fungible-token via npm).