Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compatible] Add parameter to stop the chain after given slot #13570

Closed
wants to merge 11 commits into from

Conversation

joaosreis
Copy link
Member

@joaosreis joaosreis commented Jul 11, 2023

This PR introduces an optional parameter to the CLI (slot-tx-end), that defines the slot after which the node should reject new transactions and stop including any in blocks (in case the node is a BP). This functionality is part of the hard fork mechanism.

Summary of changes:

  • Add optional slot-tx-end parameter to CLI.
  • BP always uses an empty set of transactions to produce blocks after the slot-tx-end slot instead of fetching them from the transaction pool.
  • The RPC function for sending user commands rejects commands after the slot-tx-end slot.
  • The node doesn't try to add incoming transactions to the network pool after the slot-tx-end slot.
  • The transaction pool drops all transactions when the slot-tx-end slot is reached.

Some unit tests (specifically, for the transaction pool) were added. The complete set of expected behaviors was demonstrated in a sandbox network.

@joaosreis joaosreis marked this pull request as ready for review September 7, 2023 07:37
@joaosreis joaosreis requested review from a team as code owners September 7, 2023 07:37
@joaosreis
Copy link
Member Author

!ci-build-me

Copy link
Contributor

@mitschabaude mitschabaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

product approval without review

@joaosreis joaosreis changed the title Add parameter to stop the chain after given slot [compatible] Add parameter to stop the chain after given slot Sep 17, 2023
@joaosreis joaosreis marked this pull request as draft September 28, 2023 07:59
@joaosreis
Copy link
Member Author

Closed in favor of #14516

@joaosreis joaosreis closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add parameter to stop accepting transactions after given slot
2 participants