Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Revive replayer test #13702

Merged
merged 1 commit into from
Dec 13, 2023
Merged

[CI] Revive replayer test #13702

merged 1 commit into from
Dec 13, 2023

Conversation

dkijania
Copy link
Member

@dkijania dkijania commented Jul 24, 2023 •
edited
Loading

Explain your changes:
Enable Replayer tests for berkeley

Explain how you tested your changes:

Job is enabled and green

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@dkijania dkijania changed the base branch from develop to berkeley July 24, 2023 21:10
@dkijania
Copy link
Member Author

!ci-build-me

3 similar comments
@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania dkijania force-pushed the dkijania/revive_replayer_test branch from 0bd0cbd to 6f196a8 Compare July 26, 2023 10:45
@dkijania
Copy link
Member Author

!ci-build-me

2 similar comments
@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania dkijania changed the title Dkijania/revive replayer test [CI] Revive replayer test Aug 15, 2023
@dkijania
Copy link
Member Author

!ci-build-me

@dkijania dkijania force-pushed the dkijania/revive_replayer_test branch from 05fa1cf to 8ca2daa Compare November 12, 2023 16:55
@dkijania
Copy link
Member Author

!ci-build-me

1 similar comment
@dkijania
Copy link
Member Author

!ci-build-me

@dkijania dkijania marked this pull request as ready for review December 12, 2023 23:02
@dkijania dkijania requested review from a team as code owners December 12, 2023 23:02
@dkijania
Copy link
Member Author

!ci-build-me

1 similar comment
@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Revive replayer test:
bb8a13f 
- update dump
- use dockers
@dkijania dkijania force-pushed the dkijania/revive_replayer_test branch from ba618dc to bb8a13f Compare December 13, 2023 11:34
@dkijania
Copy link
Member Author

!ci-build-me

SanabriaRusso
SanabriaRusso approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@SanabriaRusso SanabriaRusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reintroduction of test with successful CI runs.

@dkijania dkijania self-assigned this Dec 13, 2023
@dkijania dkijania merged commit 2d8ae53 into berkeley Dec 13, 2023
29 checks passed
@dkijania dkijania deleted the dkijania/revive_replayer_test branch December 13, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanabriaRusso SanabriaRusso SanabriaRusso approved these changes

Assignees

@dkijania dkijania

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkijania @SanabriaRusso