Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve fork config generation for berkeley #14270

Closed
wants to merge 16 commits into from
Closed

Improve fork config generation for berkeley #14270

wants to merge 16 commits into from

Conversation

Sventimir
Copy link
Contributor

Explain your changes:

Explain how you tested your changes:

  • Connect to a testnet and extract the ledger.
  • CI.

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@Sventimir Sventimir requested a review from a team as a code owner October 5, 2023 09:16
@Sventimir Sventimir self-assigned this Oct 5, 2023
@Sventimir Sventimir requested a review from a team as a code owner October 5, 2023 09:16
@Sventimir Sventimir changed the base branch from develop to berkeley October 5, 2023 09:16
@Sventimir
Copy link
Contributor Author

!ci-build-me

This was referenced Oct 5, 2023
Merged
Closed
Merged
@Sventimir
Copy link
Contributor Author

!ci-build-me

@Sventimir Sventimir force-pushed the sventimir/fix-fork-config-generation-berkeley branch from abe98e0 to eff2f2a Compare October 11, 2023 08:28
@Sventimir
Copy link
Contributor Author

!ci-build-me

@snaitmouloud-mf
Copy link

@bkase any chance to review this PR ?

@Sventimir
Copy link
Contributor Author

!ci-build-me

@ejMina226
Copy link
Member

!ci-build-me

@ghost-not-in-the-shell
Copy link
Contributor

ghost-not-in-the-shell commented Dec 20, 2023 •
edited
Loading

Can you cherry-pick the changes you did here: 27157c9 into this PR too? Also you might want to run make reformat to prettify the runtime_config.ml

@ejMina226
Copy link
Member

Hi @ghost-not-in-the-shell . I've cherry-picked the changes. Can you review when you are free and I can merge? Thanks.

@ejMina226
Copy link
Member

!ci-build-me

@ejMina226
Copy link
Member

!ci-build-me

@ghost-not-in-the-shell ghost-not-in-the-shell force-pushed the sventimir/fix-fork-config-generation-berkeley branch from 4165322 to 1977772 Compare December 20, 2023 19:30
@ghost-not-in-the-shell
Copy link
Contributor

!ci-build-me

Tang Jiawei added 2 commits December 21, 2023 04:23
reformat
c6247f2
Merge branch 'sventimir/fix-fork-config-generation-berkeley' of githu…
011801a 
…b.com:MinaProtocol/mina into sventimir/fix-fork-config-generation-berkeley
@ghost-not-in-the-shell
Copy link
Contributor

!ci-build-me

@Sventimir
Copy link
Contributor Author

!ci-build-me

@Sventimir
Copy link
Contributor Author

This will be redone after #14266 gets approved to more easily include all the commits that went into it.

@Sventimir Sventimir closed this Jan 3, 2024
@Sventimir Sventimir deleted the sventimir/fix-fork-config-generation-berkeley branch January 3, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejMina226 ejMina226 ejMina226 left review comments

@MartinMinkov MartinMinkov MartinMinkov approved these changes

@ghost-not-in-the-shell ghost-not-in-the-shell ghost-not-in-the-shell approved these changes

Assignees

@Sventimir Sventimir

Labels
hard fork MinaFoundation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC] Export genesis ledger for hard fork.
5 participants
@Sventimir @snaitmouloud-mf @ejMina226 @ghost-not-in-the-shell @MartinMinkov