[CI] Optimize rosetta docker #14272
Merged
[CI] Optimize rosetta docker #14272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
dkijania
force-pushed
the
clean_rosetta_toolchain_dockers
branch
from
dee9262 to
a8274a5
Compare
dkijania
force-pushed
the
clean_rosetta_toolchain_dockers
branch
from
a8274a5 to
eab5933
Compare
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
… into clean_rosetta_toolchain_dockers
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
dkijania
changed the title
|
!ci-build-me |
mrmr1993
approved these changes
Oct 18, 2023
dockerfiles/Dockerfile-mina-rosetta
Outdated
| @@ -89,8 +88,17 @@ RUN export GOBIN="$(pwd)/bin" \ | |||
| && /usr/lib/go/bin/go mod tidy \ | |||
| && /usr/lib/go/bin/go install | |||
|
|
|||
| # Rosetta-demo artifacts / build dir removal: | |||
There was a problem hiding this comment.
Is this documentation for running the test locally? It would be better to move this to somewhere more discoverable (or just delete it).
|
!ci-build-me |
Sventimir
approved these changes
Oct 19, 2023
| # RUN curl -sSfL https://raw.githubusercontent.com/coinbase/rosetta-cli/${ROSETTA_CLI_VERSION}/scripts/install.sh | sh -s | ||
| COPY --from=builder /usr/lib/go /usr/lib/go | ||
| RUN apt-get install -y gcc | ||
| #RUN curl -sSfL https://raw.githubusercontent.com/coinbase/rosetta-cli/${ROSETTA_CLI_VERSION}/scripts/install.sh | sh -s |
There was a problem hiding this comment.
Why is this line commented out? If it's unnecessary, let's delete it.
There was a problem hiding this comment.
There is an explanation above to uncomment this line once coinbase fix delegation transaction support
|
!approved-for-mainnet |
|
!ci-build-me |
|
!ci-build-me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned rosetta dockerfile. Before rosetta docker build process was split into 3 stages. Unfortunately 2 stages were building mina deamon which cause unnecessary long docker build execution. I also move all rosetta related steps into single docker. I don't know if that was necessary, but if in the future we would like to clean toolchain docker, it is easier now, as i extracted all rosetta needed steps into different docker