Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chunking for public input #14314

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Chunking for public input #14314

merged 3 commits into from
Oct 11, 2023

Conversation

mrmr1993
Copy link
Member

This PR introduces chunking for the public input of step circuits in the wrap verifier. This PR builds upon #14284.

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@mrmr1993 mrmr1993 requested a review from a team as a code owner October 10, 2023 05:36
@mrmr1993
Copy link
Member Author

!ci-build-me

@mrmr1993
Copy link
Member Author

!ci-build-me

@mrmr1993 mrmr1993 mentioned this pull request Oct 10, 2023
Merged
7 tasks
Base automatically changed from feature/more-chunks to develop October 10, 2023 08:23
@mrmr1993
Copy link
Member Author

!ci-build-me

rbonichon
rbonichon approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@rbonichon rbonichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mrmr1993
Copy link
Member Author

!ci-build-me

dannywillems
dannywillems approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@dannywillems dannywillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannywillems dannywillems merged commit aead6fa into develop Oct 11, 2023
@dannywillems dannywillems deleted the feature/even-more-chunks branch October 11, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannywillems dannywillems dannywillems approved these changes

@rbonichon rbonichon rbonichon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrmr1993 @rbonichon @dannywillems