Add support to wrap prover for verifying chunked step proofs #14331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
Merged
| @@ -1561,6 +1563,7 @@ module Make_str (_ : Wire_types.Concrete) = struct | |||
| ~endo:Endo.Step_inner_curve.base | |||
| ~mds:Tick_field_sponge.params.mds | |||
| ~srs_length_log2:Common.Max_degree.step_log2 | |||
| ~zk_rows:3 | |||
There was a problem hiding this comment.
Nit: having a constant somewhere we use everywhere would be nice.
dannywillems
approved these changes
Oct 16, 2023
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
This was referenced Oct 17, 2023
|
!ci-build-me |
mitschabaude
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the remaining bugs in the wrap prover for handling chunked step proofs.
To achieve this, this PR
zk_rows = 3in the generated expressionnum_chunksparameter toPickles.compile, to allow for the creation of proofs using a different number of chunks.With these changes, this PR now passes the local test for creating proofs using chunks in pickles. The last remaining stage is verifying those proofs recursively using the step circuit, which will be completed in an upcoming PR.