[berkeley] Use Proof_cache for more transaction snark tests, make tests deterministic #14358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
nholland94
reviewed
Oct 17, 2023
| @@ -993,4 +1011,11 @@ let%test_module "Account precondition tests" = | |||
| failwith | |||
| "Expected transaction to fail due to invalid account \ | |||
| precondition in the fee payer" ) ) | |||
|
|
|||
| let () = | |||
| match Sys.getenv_opt "PROOF_CACHE_OUT" with | |||
There was a problem hiding this comment.
What happens here if we run unit tests with -only-test flags? Would we get a proof cache out at the end which is missing some of the necessary proofs?
There was a problem hiding this comment.
Only if you also set the PROOF_CACHE_OUT environment variable (see here).
There was a problem hiding this comment.
So basically: don't do that :)
nholland94
approved these changes
Oct 17, 2023
|
!ci-build-me |
|
!approved-for-mainnet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon #14031, using the
Proof_cachemechanism to cache more proofs generated in the transaction snark tests.In order for this to work, this PR also replaces some uses of the non-deterministic
Private_key.createwith thePrivate_key.genquickcheck generator, so that we achieve cache hits for all of the relevant tests.Checklist: