Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparse ledger changes to support dynamic account creation #14520

Closed
wants to merge 5 commits into from

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Nov 6, 2023

This PR tweaks the sparse ledger implementation to

  • track the number of allocated accounts in the ledger
  • support allocating additional accounts
  • support reading, writing, and getting paths for locations that are 'empty' (i.e. after the last allocated account).

To achieve this, Sparse_ledger.find_index_exn has been replaced with a new Sparse_ledger.find_index, along with a limited set of other changes.

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them

@mrmr1993
Copy link
Member Author

mrmr1993 commented Nov 6, 2023

!ci-build-me

@mrmr1993
Copy link
Member Author

mrmr1993 commented Nov 6, 2023

!ci-nightly-me

@mrmr1993
Copy link
Member Author

Breaking change; closing.

@mrmr1993 mrmr1993 closed this Nov 21, 2023
@mrmr1993 mrmr1993 deleted the feature/allow-empty-sparse-ledger branch November 21, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant