-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soft limit zkApp commands per block #14644
Conversation
!ci-build-me |
b0d2e0e
to
3102d92
Compare
!ci-build-me |
3102d92
to
4839a88
Compare
!ci-build-me |
we'll wait until discussion on the RFC settles before checking out the PR 👍 |
8e4379e
to
83b0b1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the PR, we need some way to make this option dynamically configurable at runtime for the purposes of the authorized GraphQL server for ITN. Given that, it probably makes sense to store a ref
somewhere in the application, which gets initialized the the compile time configuration at startup, and can be set dynamically during the daemon's runtime. Then the block producer code can read from that ref when it produces a block.
Thanks for your comments, @nholland94. I'll incorporate them. Please note, though, that this is still a draft. It's not yet complete or ready for review. As to configuring the limit dynamically, I'm wary of putting refs at random places in the code. I'd much rather store it in some existing configuration struct so that it's easier to find when looked for. That's why I put it in |
!ci-build-me |
bba43ee
to
d89299e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should test these changes before landing this work. It doesn't seem the dynamic switching of the soft limit works as written. Also, I would like of you can address the comments I left before about the max size violation on staged ledger diff and the optional arguments.
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-build-me |
!approved-for-mainnet |
!ci-build-me |
Explain your changes:
Explain how you tested your changes:
Checklist: