Dissolution, physical erosion and emperical denudation impletement

[xyl96]

Adding new features including chemical dissolution, physical erosion and emperical denudation into the main branch. Unit test is not included and will be included afterwards. Please check it and we can discuss whether these codes meet the goals set in the documentation.

[xyl96]

Hi @jhidding , we met a problem:

ERROR: MethodError: no method matching Facies(; viability_range::Tuple{…}, activation_range::Tuple{…}, maximum_growth_rate::Quantity{…}, extinction_coefficient::Quantity{…}, saturation_intensity::Quantity{…}, reactive_surface::Quantity{…}, mass_density::Quantity{…}, infiltration_coefficient::Float64). 

This basically says the defination of Facies is still in the old version, while the Facies I am now using is new version (i.e., with reactivesurface, density and infiltration co-eff). We know it's gonna be solved in DSL branch but what sbould we do right now?

[jhidding]

Are you importing it from CarboKitten.Burgess2013 ?

[EmiliaJarochowska]

yes

[EmiliaJarochowska]

Different question:

CarboKitten.jl/examples/denudation/caps-miller_diss.jl

Line 12 in 86f5730

using CarboKitten.Denudation: Dissolution, NoDenudation, PhysicalErosionParam, EmpericalDenudationParam

is not importing e.g. Dissolution from DissolutionMod, it seems each struct needs to be imported individually in a separate line. Is there a clever way of doing this?

[jhidding]

That I don't understand: all the relevant structs are exported in CarboKitten.Denudation, so using CarboKitten.Denudation should suffice.

[xyl96]

That I don't understand: all the relevant structs are exported in CarboKitten.Denudation, so using CarboKitten.Denudation should suffice.

[jhidding]

@xyl96 I assume that was an accident?

[xyl96]

@xyl96 I assume that was an accident?

if only using
CarboKitten.Denudation
does not work, I have to use:
CarboKitten.Denudation: Dissolution
to make it work.

[jhidding]

That's not behaviour I can reproduce. The relevant structs are explicitly exported in src/Denudation.jl and that's the beviour I observe when doing:

julia> using CarboKitten.Denudation

julia> methods(Dissolution)
# 3 methods for type constructor:
 [1] Dissolution(; temp, precip, pco2, reactionrate)
     @ /mnt/data/Projects/mind-the-gap/CarboKitten.jl/src/Denudation/DissolutionMod.jl:13
 [2] Dissolution(temp::Unitful.Quantity{Float64, 𝚯, Unitful.FreeUnits{(K,), 𝚯, nothing}}, precip::Unitful.Quantity{Float64, 𝐋, Unitful.FreeUnits{(m,), 𝐋, nothing}}, pco2::Unitful.Quantity{Float64, 𝐌 𝐋^-1 𝐓^-2, Unitful.FreeUnits{(atm,), 𝐌 𝐋^-1 𝐓^-2, nothing}}, reactionrate::Unitful.Quantity{Float64, 𝐋 𝐓^-1, Unitful.FreeUnits{(m, yr^-1), 𝐋 𝐓^-1, nothing}})
     @ /mnt/data/Projects/mind-the-gap/CarboKitten.jl/src/Denudation/DissolutionMod.jl:14
 [3] Dissolution(temp, precip, pco2, reactionrate)
     @ /mnt/data/Projects/mind-the-gap/CarboKitten.jl/src/Denudation/DissolutionMod.jl:14

[xyl96]

That's not behaviour I can reproduce. The relevant structs are explicitly exported in src/Denudation.jl and that's the beviour I observe when doing:

julia> using CarboKitten.Denudation

julia> methods(Dissolution)
# 3 methods for type constructor:
 [1] Dissolution(; temp, precip, pco2, reactionrate)
     @ /mnt/data/Projects/mind-the-gap/CarboKitten.jl/src/Denudation/DissolutionMod.jl:13
 [2] Dissolution(temp::Unitful.Quantity{Float64, 𝚯, Unitful.FreeUnits{(K,), 𝚯, nothing}}, precip::Unitful.Quantity{Float64, 𝐋, Unitful.FreeUnits{(m,), 𝐋, nothing}}, pco2::Unitful.Quantity{Float64, 𝐌 𝐋^-1 𝐓^-2, Unitful.FreeUnits{(atm,), 𝐌 𝐋^-1 𝐓^-2, nothing}}, reactionrate::Unitful.Quantity{Float64, 𝐋 𝐓^-1, Unitful.FreeUnits{(m, yr^-1), 𝐋 𝐓^-1, nothing}})
     @ /mnt/data/Projects/mind-the-gap/CarboKitten.jl/src/Denudation/DissolutionMod.jl:14
 [3] Dissolution(temp, precip, pco2, reactionrate)
     @ /mnt/data/Projects/mind-the-gap/CarboKitten.jl/src/Denudation/DissolutionMod.jl:14

Yes I know, we have exported from Denudation.jl, but when trying to run it, it just says ```Dissolution not defined'''
May be I can show you this tmrw online.

[jhidding]

Ok, a little bit on communication here: when you're claiming something doesn't work, be very precise: what are you running and what is the exact error you're getting? Don't be lazy here.

[jhidding]

Don't do this kind of SHIT!