Removed unnecessary void parameters #21
Conversation
|
Smaller refactors are better than big ones... Try not to stuff everything in at once. :) Looks like there is a conflict... rebase! |
Right! I was thinking I could separate them by commit, but would you prefer I do each one in a separate branch? |
Only relevant in C code, not C++.
afritz1
changed the title
|
It was my original intent to have each set of logical changes in its own group, and now it is clear to me that my definition of "group" here means branch (or pull request), not commit 😄 Since a lot of changes in the near future may be project-wide, they will be somewhat large until things level out, but again, I'll keep them in logically-separated components, which should be easy. |
render/win/wglext.h
Outdated
| @@ -501,10 +501,10 @@ typedef BOOL (WINAPI * PFNWGLCHOOSEPIXELFORMATARBPROC) (HDC hdc, const int *piAt | |||
| #define WGL_ARB_make_current_read 1 | |||
| #ifdef WGL_WGLEXT_PROTOTYPES | |||
| extern BOOL WINAPI wglMakeContextCurrentARB (HDC hDrawDC, HDC hReadDC, HGLRC hglrc); | |||
| extern HDC WINAPI wglGetCurrentReadDCARB (void); | |||
| extern HDC WINAPI wglGetCurrentReadDCARB (); | |||
There was a problem hiding this comment.
wglext.h is an OpenGL header (for WIndows systems). It's not C++-specific, nor project-specific, so we probably shouldn't change it.
I'm actually a bit surprised it's included in the code base, but I guess MSVC doesn't have it (or it has an older version)?
There was a problem hiding this comment.
I was just looking at that a minute ago, too, and since it's extern it probably shouldn't be changed. Good call.
My GLEW_INCLUDE_DIR is in the AMD APP SDK and it doesn't have wglext.h, so I guess it needs to be in the codebase?
|
Let us know when the PR is ready... I'm assuming it's ready because there is no [do not merge] or other such preamble in the title. :) |
|
Ready! I have one other for virtual/override/default that I'll need to rebase after this PR is merged. |
I'll be adding some commits to this PR based on the points laid out in issue #14.
All changes here will be non-functional, and will not affect the behavior of the codebase. Basically just replacing C stuff with C++11/14 stuff and getting rid of some warnings.