Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RANKED_TFT_DOUBLE_UP, update RANKED_TFT_PAIRS QueueTypes #88

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Add RANKED_TFT_DOUBLE_UP, update RANKED_TFT_PAIRS QueueTypes #88

merged 1 commit into from
Jun 20, 2022

Conversation

aPinat
Copy link
Contributor

@aPinat aPinat commented Jun 20, 2022

Should fix current JSON deserialization issues. Like #64

Also see RiotGames/developer-relations#574 (comment)

@MingweiSamuel
Copy link
Owner

Thanks, perfect.

I guess I should have these generate from riotapi-schema since that that data is included

@MingweiSamuel MingweiSamuel merged commit a67e075 into MingweiSamuel:release/3.x.x Jun 20, 2022
@MingweiSamuel
Copy link
Owner

3.0.0-nightly-2022-06-20-a67e075397

@aPinat
Copy link
Contributor Author

aPinat commented Jun 20, 2022

Thanks, perfect.

I guess I should have these generate from riotapi-schema since that that data is included

Yeah I wasn't too confident to do it myself, but it was an idea since #64 #65.

@aPinat aPinat deleted the updateDoubleUpQueue branch June 20, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aPinat @MingweiSamuel