-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VRP refactoring #10
base: master
Are you sure you want to change the base?
VRP refactoring #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, there is just one issue: in the vrp.mzn file, K is assigned to N, so now by adding an assignment for K in the data files causes an error when running vrp.mzn:
MiniZinc: type error: multiple assignment to the same variable
In my opinion, the best and easiest fix for this would be to replace "int: K = N;" with "int: K;" in the vrp.mzn file.
The first commit renames On my working copy:
|
Of course, you are right, thanks for clarifying. Then everything should be OK 👍 |
Thanks a lot for your work on this! I think we'll need to reorganise the repositories a bit before merging this one. Currently this repo has a dual role: as a set of benchmarks, but also to collect previous challenge problems. For the challenge problems, I would like to avoid renaming and modifying models. It's probably best to set up a separate repository with all only the challenge models and instances, exactly as they were run. Then we're free to make changes to this one without causing too much confusion. Does that make sense? |
Yes, that makes sense. |
The library has two models for the Capacitated Vehicle Routing Problem: A MIP model in
vrp
and a CP model incvrp
. Both directories contain instances but the instances incvrp
are a subset of those invrp
. The instance files have names likeA-n32-k5.vrp.dzn
where n is the number of customers and k is the number of vehicles. However, the instance files do not contain k and the models assume that k equals n.This PR solves both issues:
vrp
tocvrp
.k
.k
.