Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storyline lore #476

Closed
wants to merge 12 commits into from
Closed

Storyline lore #476

wants to merge 12 commits into from

Conversation

Litorom
Copy link
Member

@Litorom Litorom commented May 15, 2023

Adds lore pages/books to be found in chests
Follows the original theme alone and Obsidian Knight hold on further growth.

Copy link
Member

@Makkkkus Makkkkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid grammatical mistakes. Perhaps attempt to to a website that can improve your writing? For example: "Knight" should only be written with a capital "K" in the start of sentences. In addition, "..." is acceptable", but in those cases I advise you to consistently follow the AP stylebook.

I also notice some weird choices when it comes to the words and sentences you create. "Throughout countless eons" and "Banished from their home to fend in another world", for example. "Once upon a time, in a space far far away", makes no sense at all. What is a space? It is incredibly ambigous. Also, Star Wars?

I also see some mixing of British and American English (GB: "learnt", US: "armor"). Try using one consistently instead of mixing the two. Ideally you would use British English, but that is personal taste.

In difference to form, the actual contents are pretty good. Just fix up these minor issues and you'll be set.

@Litorom
Copy link
Member Author

Litorom commented Jun 20, 2023

Please avoid grammatical mistakes. Perhaps attempt to to a website that can improve your writing? For example: "Knight" should only be written with a capital "K" in the start of sentences. In addition, "..." is acceptable", but in those cases I advise you to consistently follow the AP stylebook.

I also notice some weird choices when it comes to the words and sentences you create. "Throughout countless eons" and "Banished from their home to fend in another world", for example. "Once upon a time, in a space far far away", makes no sense at all. What is a space? It is incredibly ambigous. Also, Star Wars?

I also see some mixing of British and American English (GB: "learnt", US: "armor"). Try using one consistently instead of mixing the two. Ideally you would use British English, but that is personal taste.

In difference to form, the actual contents are pretty good. Just fix up these minor issues and you'll be set.

I see, I understand that my writing is wonky at times. As for “Obsidian Knight” is a person (entity), I feel should be capitalized. As for British vs American English, “learnt” i didn’t know was a British term.

@Makkkkus
Copy link
Member

Makkkkus commented Jun 20, 2023

The "Obsidian Knight" and a "Knight" are two completely different things.

@Litorom
Copy link
Member Author

Litorom commented Jun 20, 2023

The "Obsidian Knight" and a "Knight" are two completely different things.

Yes, I realized that one capitalized “Knight” now. I’ll fix that grammar.

@Makkkkus
Copy link
Member

Closing because of lacking activity.

@Makkkkus Makkkkus closed this Jul 19, 2023
@Litorom Litorom reopened this Aug 15, 2023
@BenCheung0422
Copy link
Member

BenCheung0422 commented Aug 22, 2023

There could be some types of lore books:

  • pages - a complete page of the storyline describing the story.
  • pieces of papers - a part of a page, may be including placeholders like [Lost content] or [Unclear content], "The text written left is blur and unclear".
  • book series - a complete part of a set of book series (maybe a singleton book), may be story books.

Then, we could have different types of contents in the books:

  • diaries - texts left or daily living/adventure experiences written by forerunners or some mobs included in the historical storyline.
  • god's text - messages by the story narrator.
  • stories - some stories written by somethings or describing the storyline.

@BenCheung0422
Copy link
Member

BenCheung0422 commented Aug 22, 2023

As Eye mentioned that the game without a fixed story might be more attractive to people, I would like to suggest that we should keep this storyline lore be small and concise, without overinterpreting the storyline. Also, the lore should be kept as the background of the game, so it is the story of the game. By the way, there has already been "Antidious" in the game, which is written in 2012 as a short story, so we should also include this story in the game. The book is dropped by skeleton with a small chance. The story guide can be taken as the reference.

@Litorom Litorom added the Improvement Ideas for changes to features or content. label Nov 9, 2023
@Litorom Litorom closed this Jan 31, 2024
@BenCheung0422
Copy link
Member

Actually I think of a way to implement lore book generation better with help of the world generation tweaks.

@Litorom
Copy link
Member Author

Litorom commented Feb 1, 2024

That doesn’t change the issue with old worlds. We don’t have pointers to old structures like abandoned villages to add or spawn a chest to.

@BenCheung0422
Copy link
Member

Well, we can have a temporary item that can be crafted and used to generate the desired structures. This item can be disused and made as souvenir when infinity generation is done.

@Litorom
Copy link
Member Author

Litorom commented Feb 1, 2024

Tbh thats not a bad idea however, it could theoretically be exploited and overpowered. To a certain degree we could prevent this but idk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Ideas for changes to features or content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants