Fixes world generation display name input entry rendering problem #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makkkkus
reviewed
Jun 15, 2023
|
This part of the gui system has to be rewritten. It isn't important enough to fix the error with "duct-tape". |
|
This is just a simple fix. |
|
It isn't a simple fix. I'm almost certain this will break something. |
|
No, I have tested. This only improves the behaviour of world name input. |
|
The original code does break something, so I am going to implement this in a more general way as this affects more entries and menus in more situations in fact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #486.
The original input entry renders unwisely, which means the entry is rendered with weird displacement, it is unable to check out the texts on the left when the string is longer than the width, also, the position of the entry to displace is not set ideally, it is intended to render precisely but it is not. So, this modifies these behaviours. It is now rendered correctly, and the right arrow on the left also moves according to the displacement of the entry. Also, it is now able to move the entry inspection to the left or to the right by using left and right keys respectively. When changes applied to the entry, the position resets.