Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix steppedOn and bumpedOn x and y positions #601

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

KalmeMarq
Copy link
Member

In Entity::moveByEntityHitBoxChecks, when calling the bumpingHandler and steppingHandler the horTile and frontTile were switched. This fixes sand particles spawning in the wrong tiles.

The lambda accepts horTile (X-axis) and front (Y-axis). However, in the moveByEntityHitBoxChecks calls the names are switched. So horTile is being used in the Y-axis and front in the X-axis.
@KalmeMarq KalmeMarq added the Bug Something that shouldn't happen. label Dec 30, 2023
Copy link
Member

@BenCheung0422 BenCheung0422 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot. I think it resolves.

Copy link
Member

@Litorom Litorom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually forgot to approve when I tested this. I saw no problems and appears to have fixed the bug.

@Litorom Litorom merged commit 7ede822 into MinicraftPlus:main Jan 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something that shouldn't happen.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants