Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEOPY-1971: Octree mesh upside down (backport for Analyst 4.5.1) #695

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

domfournier
Copy link
Contributor

@domfournier domfournier commented Jan 31, 2025

GEOPY-1971 - Octree mesh upside down (backport for Analyst 4.5.1)
(cherry picked from commit 6e6806c)

(cherry picked from commit 6e6806c)
@github-actions github-actions bot changed the title GEOPY-1971 GEOPY-1971: Octree mesh upside down (backport for Analyst 4.5.1) Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.64%. Comparing base (0ed8adc) to head (71d69a2).
Report is 3 commits behind head on hotfix/0.10.1.

Files with missing lines Patch % Lines
geoh5py/objects/octree.py 33.33% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           hotfix/0.10.1     #695      +/-   ##
=================================================
- Coverage          90.73%   90.64%   -0.10%     
=================================================
  Files                107      107              
  Lines               9052     9061       +9     
  Branches            1682     1685       +3     
=================================================
  Hits                8213     8213              
- Misses               452      458       +6     
- Partials             387      390       +3     
Files with missing lines Coverage Δ
geoh5py/objects/grid_object.py 100.00% <100.00%> (+3.70%) ⬆️
geoh5py/objects/octree.py 85.71% <33.33%> (-4.03%) ⬇️

... and 1 file with indirect coverage changes

@domfournier domfournier merged commit 2abb8b5 into hotfix/0.10.1 Feb 3, 2025
13 checks passed
@domfournier domfournier deleted the GEOPY-1971 branch February 3, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants