Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEOPY-1291 #16

Closed
wants to merge 20 commits into from
Closed

GEOPY-1291 #16

wants to merge 20 commits into from

Conversation

benk-mira
Copy link
Contributor

@benk-mira benk-mira commented Jan 10, 2024 •
edited by github-actions bot
Loading

GEOPY-1291 - Update copyright

benk-mira and others added 16 commits November 10, 2023 14:12
@benk-mira
Cleanup file skipper for value error in add_data since adding propert…
1be33f1 
…y gruop incrementeer
@benk-mira
poetry update
214c396
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
3fff14b 
for more information, see https://pre-commit.ci
@benk-mira
Merge branch 'develop' into GEOPY-1147
c3bfe47
@benk-mira
Merge branch 'GEOPY-1147' of github.com:MiraGeoscience/las-geoh5 into G…
d8a2a4e 
…EOPY-1147
@benk-mira
increment property group
0f01c73
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
6c44205 
for more information, see https://pre-commit.ci
@benk-mira
fix pre-commit
0b6087d
@benk-mira
Merge branch 'GEOPY-1147' of github.com:MiraGeoscience/las-geoh5 into G…
7f8479e 
…EOPY-1147

# Conflicts:
#	tests/import_las_test.py
@benk-mira
update lock file after geoh5py 1147 merged
7c0542f
@benk-mira
ignore las_geoh5/.idea
6eb5605
@benk-mira
ignore .idea
fec29e5
@benk-mira
remove tracking for .idea
03fb183
@benk-mira
clean .gitignore
064839e
@benk-mira
Prevent property_group creation and add_data call if no data to be ad…
edaeeee 
…ded. Causes broken geoh5 file (property group with no depth table).
@benk-mira
copyright update
0219342
@benk-mira benk-mira requested a review from domfournier January 10, 2024 22:03
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8910f72) 81.56% compared to head (17e8cae) 83.12%.

❗ Current head 17e8cae differs from pull request most recent head 0eb38a0. Consider uploading reports for the commit 0eb38a0 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop      #16      +/-   ##
===========================================
+ Coverage    81.56%   83.12%   +1.55%     
===========================================
  Files            9        9              
  Lines          396      397       +1     
  Branches        83       84       +1     
===========================================
+ Hits           323      330       +7     
+ Misses          48       43       -5     
+ Partials        25       24       -1
Files Coverage Δ
las_geoh5/export_directories/driver.py 64.28% <ø> (ø)
las_geoh5/export_directories/uijson.py 100.00% <ø> (ø)
las_geoh5/export_las.py 80.76% <ø> (ø)
las_geoh5/import_directories/driver.py 65.71% <ø> (ø)
las_geoh5/import_directories/uijson.py 100.00% <ø> (ø)
las_geoh5/import_files/driver.py 86.56% <ø> (ø)
las_geoh5/import_files/uijson.py 100.00% <ø> (ø)
las_geoh5/import_las.py 91.55% <100.00%> (+3.97%) ⬆️
las_geoh5/uijson/write_uijson.py 71.42% <ø> (ø)

@benk-mira benk-mira closed this Jan 10, 2024
@benk-mira benk-mira deleted the GEOPY-1291 branch January 10, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domfournier domfournier Awaiting requested review from domfournier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benk-mira