Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEOPY-1320: Add collocation tolerance option in ui.json and import_files driver #26

Merged
merged 14 commits into from
Mar 5, 2024

Conversation

benk-mira
Copy link
Contributor

@benk-mira benk-mira commented Feb 22, 2024

GEOPY-1320 - Add collocation tolerance option in ui.json and import_files driver

@github-actions github-actions bot changed the title GEOPY-1320 GEOPY-1320: Add collocation tolerance option in ui.json and import_files driver Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 93.61702% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 83.56%. Comparing base (8bbf3ac) to head (fe9a41d).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #26      +/-   ##
===========================================
- Coverage    84.04%   83.56%   -0.49%     
===========================================
  Files            9       10       +1     
  Lines          420      432      +12     
  Branches        93       94       +1     
===========================================
+ Hits           353      361       +8     
- Misses          42       44       +2     
- Partials        25       27       +2     
Files Coverage Δ
las_geoh5/import_directories/driver.py 66.66% <100.00%> (+0.95%) ⬆️
las_geoh5/import_files/driver.py 88.31% <100.00%> (+0.31%) ⬆️
las_geoh5/import_files/params.py 100.00% <100.00%> (ø)
las_geoh5/import_files/uijson.py 100.00% <ø> (ø)
las_geoh5/import_las.py 89.37% <86.95%> (-2.94%) ⬇️

# Conflicts:
#	las_geoh5/import_files/driver.py
#	las_geoh5/import_las.py
#	tests/geoh5_to_las_test.py
# Conflicts:
#	tests/import_las_test.py
# Conflicts:
#	las_geoh5/import_las.py
#	las_geoh5_assets/uijson/import_las_files.ui.json
#	poetry.lock
#	tests/import_las_test.py
Copy link
Contributor

@domfournier domfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. See comments

las_geoh5/import_files/params.py Outdated Show resolved Hide resolved
las_geoh5/import_files/driver.py Outdated Show resolved Hide resolved
las_geoh5/import_files/params.py Show resolved Hide resolved
@domfournier domfournier self-requested a review March 5, 2024 16:36
@domfournier domfournier merged commit dc52fbd into develop Mar 5, 2024
11 checks passed
@domfournier domfournier deleted the GEOPY-1320 branch March 5, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants