GEOPY-1413: Move all optional parameters to general tabs #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…og file permissions all of a sudden.
github-actions
bot
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/0.2.0 #27 +/- ##
=================================================
- Coverage 83.56% 82.72% -0.84%
=================================================
Files 10 10
Lines 432 440 +8
Branches 94 97 +3
=================================================
+ Hits 361 364 +3
- Misses 44 46 +2
- Partials 27 30 +3
|
domfournier
reviewed
Mar 19, 2024
There was a problem hiding this comment.
Looks good. Can you also change the toml file to use the new alpha format for geoh5py? I ll need it on GEOPY-1423
domfournier
reviewed
Mar 19, 2024
| "conda_environment_boolean": false, | ||
| "workspace": "", | ||
| "drillhole_group": { |
There was a problem hiding this comment.
I think you might have deleted too much. Getting a crash with this missing
There was a problem hiding this comment.
yep, you're right.. whoops!
domfournier
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GEOPY-1413 - Move all optional parameters to general tabs
…og file permissions all of a sudden.