Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change target #20

Closed
wants to merge 3 commits into from
Closed

Change target #20

wants to merge 3 commits into from

Conversation

domfournier
Copy link
Contributor

No description provided.

@domfournier domfournier requested a review from sebhmg May 31, 2024 16:49
sebhmg
sebhmg requested changes May 31, 2024
View reviewed changes
Copy link
Contributor

@sebhmg sebhmg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now failure is

>           assert mesh.n_cells == 10586
E           assert 15136 == 10586

@domfournier
Copy link
Contributor Author

now failure is

>           assert mesh.n_cells == 10586
E           assert 15136 == 10586

What the heck is going on... reverting

@domfournier
Copy link
Contributor Author

Don't know what to tell you, this PR doesn't do anything

@sebhmg
Copy link
Contributor

sebhmg commented May 31, 2024

What the heck is going on... reverting

Test passes here but fails when using geoh5py 0.9.0-rc in #19

@domfournier domfournier deleted the hot_fix branch May 31, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebhmg sebhmg sebhmg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domfournier @sebhmg