GEOPY-1524: Add forward validation of CNN picks #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # plate_simulation/params.py # plate_simulation/point_simulations/__init__.py
github-actions
bot
changed the title
# Conflicts: # environments/py-3.10-linux-64-dev.conda.lock.yml # environments/py-3.10-linux-64.conda.lock.yml # environments/py-3.10-win-64-dev.conda.lock.yml # environments/py-3.10-win-64.conda.lock.yml # plate_simulation/simulations/__init__.py # plate_simulation/simulations/params.py # py-3.10.conda-lock.yml # pyproject.toml # tests/runtest/driver_test.py
# Conflicts: # environments/py-3.10-linux-64-dev.conda.lock.yml # environments/py-3.10-linux-64.conda.lock.yml # environments/py-3.10-win-64-dev.conda.lock.yml # environments/py-3.10-win-64.conda.lock.yml # py-3.10.conda-lock.yml # pyproject.toml
# Conflicts: # tests/models/__init__.py # tests/runtest/__init__.py
# Conflicts: # environments/py-3.10-linux-64-dev.conda.lock.yml # environments/py-3.10-linux-64.conda.lock.yml # environments/py-3.10-win-64-dev.conda.lock.yml # environments/py-3.10-win-64.conda.lock.yml # py-3.10.conda-lock.yml # pyproject.toml
benk-mira
requested changes
Jul 10, 2024
| @@ -69,11 +69,6 @@ class PlateParams(BaseModel): | |||
| reference_surface: str = "topography" | |||
| reference_type: str = "mean" | |||
|
|
|||
| @field_validator("plate", mode="before") | |||
There was a problem hiding this comment.
Where are you doing the conversion to account for removing these? If they're resistivities in the ui.json, and remain resistivities in the params classes, then the driver needs to flip them, but I don't see that change.
There was a problem hiding this comment.
Happens in series on the whole model.
benk-mira
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GEOPY-1524 - Add forward validation of CNN picks