Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEOPY-1448: Add option to export sensitivities for all inversions #55

Merged
merged 3 commits into from
Oct 9, 2024
Merged

GEOPY-1448: Add option to export sensitivities for all inversions #55

merged 3 commits into from
Oct 9, 2024

Conversation

domfournier
Copy link

@domfournier domfournier commented Oct 7, 2024 •
edited by github-actions bot
Loading

GEOPY-1448 - Add option to export sensitivities for all inversions

Summary

PR Checklist

  • If this is a work in progress PR, set as a Draft PR
  • Linted my code according to the style guides.
  • Added tests to verify changes to the code.
  • Added necessary documentation to any new functions/classes following the
    expect style.
  • Added relevant method tags (i.e. GRAV, EM, etc.)
  • Marked as ready for review (ff this is was a draft PR), and converted
    to a Pull Request
  • Tagged @simpeg/simpeg-developers when ready for review.

Reference issue

What does this implement/fix?

Additional information

@github-actions github-actions bot changed the title GEOPY-1448 GEOPY-1448: Add option to export sensitivities for all inversions Oct 7, 2024
benk-mira
benk-mira requested changes Oct 7, 2024
View reviewed changes
Copy link

@benk-mira benk-mira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think you're covering the dmisift=None case

simpeg/directives/directives.py Outdated Show resolved Hide resolved
benk-mira
benk-mira previously approved these changes Oct 9, 2024
View reviewed changes
@domfournier @github-actions
Update simpeg/directives/directives.py
4c7f681 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@domfournier domfournier merged commit 3e62dde into develop Oct 9, 2024
4 checks passed
@domfournier domfournier deleted the GEOPY-1448 branch October 9, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benk-mira benk-mira benk-mira left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domfournier @benk-mira