Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVOPS-515: requires geoh5py 0.10 + pymatsolver constraint in conda recipe #60

Merged
merged 5 commits into from
Oct 21, 2024

Conversation

sebhmg
Copy link

@sebhmg sebhmg commented Oct 19, 2024

DEVOPS-515 - release branches to prepare distrib for Analyst 4.5

  • requires geoh5py 0.10 (pyproject.toml and conda recipe)
  • add pymatsolver constraint in Conda recipe too
  • fix black config in pre-commit and execute pre-commit

@github-actions github-actions bot changed the title Devops 515 DEVOPS-515: release branches to prepare distrib for Analyst 4.5 Oct 19, 2024
@@ -20,7 +20,7 @@ dependencies = [
"discretize>=0.10.0",
"empymod>=2.0.0",
"geoana>=0.5.0",
"geoh5py>=0.9.1,<0.11",
"geoh5py>=0.10.0-alpha.1, <0.11",
Copy link
Author

@sebhmg sebhmg Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stating that simpeg requires at geoh5py 0.10

I am not sure here: does this branch of simpeg work with geoh5 0.9, @domfournier ?
In any case, I suppose it is safer to be restrictive.

For now, geoh5py 0.10-alpha is not published to the public. Since simpeg is supposed to be installed in a Conda environment, that should be OK, as long as the environment has a geoh5py 0.10-alpha version (installed from the giithub repo, or from a published pre-release on our private conda or pip repo).
Does that sound right?
@domfournier , @SophieCurinier ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might still work for 0.9.0, but probably safer to restrict as 0.10 breaks backward compatibility on the value_maps.

@sebhmg sebhmg changed the title DEVOPS-515: release branches to prepare distrib for Analyst 4.5 DEVOPS-515: requires geoh5py 0.10 + pymatsolver constraint in conde recipe Oct 21, 2024
@sebhmg sebhmg changed the title DEVOPS-515: requires geoh5py 0.10 + pymatsolver constraint in conde recipe DEVOPS-515: requires geoh5py 0.10 + pymatsolver constraint in conda recipe Oct 21, 2024
@domfournier domfournier merged commit 498069a into release/0.21.2.1 Oct 21, 2024
5 checks passed
@domfournier domfournier deleted the DEVOPS-515 branch October 21, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants