-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEVOPS-515: requires geoh5py 0.10 + pymatsolver constraint in conda recipe #60
Conversation
@@ -20,7 +20,7 @@ dependencies = [ | |||
"discretize>=0.10.0", | |||
"empymod>=2.0.0", | |||
"geoana>=0.5.0", | |||
"geoh5py>=0.9.1,<0.11", | |||
"geoh5py>=0.10.0-alpha.1, <0.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stating that simpeg requires at geoh5py 0.10
I am not sure here: does this branch of simpeg work with geoh5 0.9, @domfournier ?
In any case, I suppose it is safer to be restrictive.
For now, geoh5py 0.10-alpha is not published to the public. Since simpeg is supposed to be installed in a Conda environment, that should be OK, as long as the environment has a geoh5py 0.10-alpha version (installed from the giithub repo, or from a published pre-release on our private conda or pip repo).
Does that sound right?
@domfournier , @SophieCurinier ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might still work for 0.9.0, but probably safer to restrict as 0.10 breaks backward compatibility on the value_maps.
DEVOPS-515 - release branches to prepare distrib for Analyst 4.5