Skip to content

Commit

Permalink
PRODENG-2719 MSR3 with no MSR2 panic (#499)
Browse files Browse the repository at this point in the history
- fix MSR2 upgrade check panic when there is no MSR2 config, but there
  is MSR3

@note that there is no MR3 upgrade check, which can be done in a future
effort

Signed-off-by: James Nesbitt <[email protected]>
  • Loading branch information
james-nesbitt authored Aug 14, 2024
1 parent 5558daf commit fbaac31
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion pkg/product/mke/phase/upgrade_check.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func (p *UpgradeCheck) Run() (err error) {
}
}

if p.Config.Spec.ContainsMSR() {
if p.Config.Spec.ContainsMSR2() {
msrv, err := hub.LatestTag("mirantis", "dtr", strings.Contains(p.Config.Spec.MSR2.Version, "-"))
if err != nil {
log.Errorf("failed to check for MSR upgrade: %s", err.Error())
Expand All @@ -79,5 +79,7 @@ func (p *UpgradeCheck) Run() (err error) {
}
}

// @TODO MSR3 version upgrade check

return nil
}

0 comments on commit fbaac31

Please sign in to comment.