PRODENG-2551 clean and fix local/release #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
james-nesbitt
commented
Mar 8, 2024
•
james-nesbitt
commented
- separate goreleaser/makefile processes for local/release build
- different goreleaser files now for local/release
- can now build/sign/release separately
- remove make target for release, which is dangerous enough that it should never be run accidentally, and just runs a script
- Jenkins podspec to separate build/sign/release
- build-release now happens in a goreleaser container
- sign-release now happens in the Mir digicert container
james-nesbitt
force-pushed
the
PRODENG-2551-fix-release-jenkins
branch
from
be64433 to
206298f
Compare
james-nesbitt
force-pushed
the
PRODENG-2551-fix-release-jenkins
branch
3 times, most recently
from
12b9a39 to
1a01d7a
Compare
james-nesbitt
force-pushed
the
PRODENG-2551-fix-release-jenkins
branch
6 times, most recently
from
b25efb5 to
175ce99
Compare
- separate goreleaser/makefile processes for local/release build - different goreleaser files now for local/release - can now build/sign/release separately - remove make target for release, which is dangerous enough that it should never be run accidentally, and just runs a script - Jenkins podspec to separate build/sign/release - build-release now happens in a goreleaser container - sign-release now happens in the Mir digicert container Signed-off-by: James Nesbitt <[email protected]>
james-nesbitt
force-pushed
the
PRODENG-2551-fix-release-jenkins
branch
from
175ce99 to
1e85eb9
Compare
cranzy
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.