Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile の runner ステージで pnpm をインストールする #284

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

riku6460
Copy link
Collaborator

@riku6460 riku6460 commented Dec 8, 2023

What

Dockerfile の runner ステージで pnpm をインストールする

Why

npmjs へのリクエストが失敗して起動しないことがあるので

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@riku6460 riku6460 requested a review from u1-liquid December 8, 2023 11:58
Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@u1-liquid u1-liquid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍👍👍👍👍👍👍

@riku6460 riku6460 merged commit d626f10 into io Dec 8, 2023
17 checks passed
@riku6460 riku6460 deleted the install-pnpm-in-runner-stage branch December 8, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants