try system test #617
Merged
try system test #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #617 +/- ##
==========================================
+ Coverage 73.25% 73.32% +0.06%
==========================================
Files 49 49
Lines 3096 3096
==========================================
+ Hits 2268 2270 +2
+ Misses 828 826 -2 ☔ View full report in Codecov by Sentry. |
MisterTea
force-pushed
the
add_github_actions_system_test
branch
from
9f523fe
to
180335d
Compare
jshort
reviewed
Apr 30, 2024
src/terminal/TerminalClientMain.cpp
Outdated
| @@ -294,6 +297,11 @@ int main(int argc, char** argv) { | |||
| } | |||
|
|
|||
| int jport = result["jport"].as<int>(); | |||
There was a problem hiding this comment.
You can remove this to as it's not used.
MisterTea
force-pushed
the
add_github_actions_system_test
branch
from
ee53c9b
to
8b18584
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.