Fix devcontainer and update vcpkg for tests #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this supersedes #618. |
|
Nice! I'll want to upgrade vcpkg further in #618 which will require making some changes in et, but this is a great PR. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devcontainer: The original
ubuntu-21.04image was failing to build, so I switched it todebian-11which works out of the box.Tests: They were failing because
libwinpthread < 10.0is not available on thehttps://repo.msys2.organymore. See for example the 404 not found errors here.So what I did for testing is I updated
vcpkgone month at the time until the tests started passing and ended up on vcpkg commit 4a3c366.