Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase socket timeout to 30s #642

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

MisterTea
Copy link
Owner

No description provided.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.26%. Comparing base (271d2a6) to head (ac9460e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #642      +/-   ##
==========================================
- Coverage   73.48%   73.26%   -0.22%     
==========================================
  Files          51       51              
  Lines        3206     3206              
  Branches      400      400              
==========================================
- Hits         2356     2349       -7     
- Misses        850      857       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jshort
Copy link
Collaborator

jshort commented Jun 3, 2024

I wonder if it is a the timeout in waitOnSocketData:

inline bool waitOnSocketData(int fd) {
  fd_set fdset;
  FD_ZERO(&fdset);
  FD_SET(fd, &fdset);
  timeval tv;
  tv.tv_sec = 1;
  tv.tv_usec = 0;
  VLOG(4) << "Before selecting sockFd";
  const int selectResult = select(fd + 1, &fdset, NULL, NULL, &tv);

Which is 1 sec, and select is repeatedly returning 0 which indicates a timeout.

@MisterTea MisterTea merged commit 4c2038e into master Jun 4, 2024
26 checks passed
@MisterTea MisterTea deleted the jgauci_increase_socket_handler_timeout branch June 4, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants