Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs #2482

Merged
merged 6 commits into from
Jul 23, 2019
Merged

Fix docs #2482

merged 6 commits into from
Jul 23, 2019

Conversation

dead-claudia
Copy link
Member

@dead-claudia dead-claudia commented Jul 23, 2019 •
edited
Loading

Description

  • Remove redundant ES6 references - it's all JS, and it's not even new. IE support is the only reason they're not used everywhere.
  • Fix a few headers for consistency.
  • Document special attributes and warn people not to use them.
  • Update the release docs so I won't forget other references.
  • Remove the opinionated CSS design pattern garbage - it has no place in the docs.
  • Update the CSS to be a bit more readable and easier to follow.
  • Rewrite the testing docs entirely to be more direct and to the point.
  • Fix a few lint issues in the ospec binary.
  • Add note about REM possibly needing third-party cookies.
  • Recast the JSX vs hyperscript comparison to be more meaningful.
  • Kill some outdated ES6 references.
  • Update the ES6 docs to be much more modern and more cleanly structured.

Motivation and Context

See: #1687 (comment)
Fixes #2414

How Has This Been Tested?

N/A - ran the tests to be safe, but that's it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes. - N/A
  • All new and existing tests passed. - N/A
  • I have updated docs/change-log.md - N/A

@dead-claudia
Fix MithrilJS#2414, address part of MithrilJS#1687
c4276bf 
Also cleared the CSS up to be a lot more readable instead of smooshed
into a single line.
@dead-claudia
Redo the testing docs page
b18cec2 
- Addresses another part of MithrilJS#1687
- Also, fix a few linter issues in the ospec binary
@dead-claudia
Add note about third-party cookies, tweak a line
1dd3717
@dead-claudia
Make the JSX comparison much more meaningful
7c3ec6c 
And let the code speak for itself. Don't fuel the flame wars any more
than what they've already become. We should be *unopinionated*, and so
I've updated those docs to remove the existing opinion.
@dead-claudia
Remove a bunch of outdated ES6 references
6c85859
@dead-claudia
Remove the CSS page
5722a34
@dead-claudia dead-claudia merged commit 20f0759 into MithrilJS:next Jul 23, 2019
@dead-claudia dead-claudia deleted the fix-docs branch July 23, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orbitbot orbitbot orbitbot left review comments

Assignees
No one assigned
Labels
None yet
Projects
Triage/bugs
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passing an object with a key of tag to a Component leaves the Component with an empty attrs
2 participants
@dead-claudia @orbitbot