64-bit integers and CI tests #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 13, 2024 15:16
…y when MMG is compiled in int 64
Algiane
reviewed
Mar 1, 2024
src/mmgs/inout_s.c
Outdated
| @@ -171,7 +172,7 @@ int MMGS_loadMesh(MMG5_pMesh mesh, const char *filename) { | |||
| } | |||
| MMG_FREAD(&mesh->ver,MMG5_SW,1,inm); | |||
| if(iswp) mesh->ver = MMG5_swapbin(mesh->ver); | |||
| while(fread(&binch,MMG5_SW,1,inm)!=0 && binch!=54 ) { | |||
| while(fread(&binch,4,1,inm)!=0 && binch!=54 ) { | |||
There was a problem hiding this comment.
Why removing the macro here? Is it not the same?
There was a problem hiding this comment.
This is a mistake. I reverted this change.
Algiane
added
kind: bug
|
Also: can you check while some tests are failing, please (https://github.com/MmgTools/mmg/actions/runs/8097282072/job/22127995683?pr=244). |
added 2 commits
March 25, 2024 16:25
…property to ctests using ELAS with int64_t
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates adds Github actions for running continuous integrations tests with 64-bit integers.
It also fixes somes bugs related to data reading in binary files.