fix: fixed undefined data before computing the plans

MoViDe-Project · Feb 3, 2025 · cc4c723 · cc4c723
1 parent 16a682a
commit cc4c723
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/visual-debugger/src/lib/components/ui/PlanOverview.svelte b/visual-debugger/src/lib/components/ui/PlanOverview.svelte
@@ -8,6 +8,11 @@
 
     // let queries be up-to-date with the store
     currentPlanStore.subscribe((data) => {
+            if (data === undefined) {
+                alert("No plans found, please compute the queries before trying to switch between their data.")
+                return
+            }
+
             itineraries = data.itineraries;
         }
     )

diff --git a/visual-debugger/src/lib/components/ui/QueryBatchOverview.svelte b/visual-debugger/src/lib/components/ui/QueryBatchOverview.svelte
@@ -31,16 +31,13 @@
                 plans = data
 
                 //if no plan was previously computed, alert the user of this
-                if (data === new Array<Plan>) {
+                if (data == new Array<Plan>) {
                     alert("No plans found, please compute the queries before trying to switch between their data.")
                     return
                 }
             }
         )
 
-        // return if the store is still empty (this means the function was called to early)
-        if (plans === new Array<Plan>) return;
-
         // load plan of the clicked query into svelte store
         currentPlanStore.set(plans[queryIndex - 1])
 
@@ -57,10 +54,7 @@
                 }
             }
         )
-
-        // return if the store is still empty (this means the function was called to early)
-        if (defaultPlans == undefined) return;
-
+        
         // load plan of the clicked query into svelte store
         currentDefaultPlanStore.set(defaultPlans[queryIndex - 1])
     }