Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement user stories of iteration 4 #47

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: Implement user stories of iteration 4 #47

wants to merge 3 commits into from

Conversation

D3vZro
Copy link
Collaborator

@D3vZro D3vZro commented Feb 7, 2025 •
edited
Loading

Additionally closes #33, #12

Checklist

Formalities:

  • PR targets staging, if compare branch is chore/* or feat/*
  • PR title is formatted as a commit
  • New functions are commented in the source file
  • Notes are added to wiki

Quality assurance:

  • Manual build and unit/component testing:
    • Linux
    • macOS
    • Windows
  • Manual End-To-End testing:
    • Upload of query batch
    • Computation of routing results
    • Download plan
    • Upload plan
    • Compare functionality

For staging -> master

  • Check for relevant open issues
  • After merge: Create release

Kvnstrck and others added 3 commits February 3, 2025 13:16
@Kvnstrck
fix: fixed undefined data before computing the plans
cc4c723
@Kvnstrck
chore: cleanup parsing of queries
08289b8
@Kvnstrck @MoPhliFra
@Kha1r0 @nicosvv
feat: implement new backend, itinerary overview, also styling (#46)
cd31589 
* chore: enforce standards and improve ease of use

* feat: implement new frontend to the logic

Co-authored-by: MoPhliFra <[email protected]>
Co-authored-by: Dominik Kuckeburg <[email protected]>

* chore: delete old frontend

* feat: PlanEntry with itinerary match attribute; style change

- added attribute to itinerary class
- changed comparePlans.ts to use match attribute instead of cssClass when match / mismatch
- changed PlanEntry style for match / mismatch

* fix: revert match to cssClass

* chore: change layout

* feat: implement itinerary overview sketch

* feat: styling of itinerary overview

---------

Co-authored-by: MoPhliFra <[email protected]>
Co-authored-by: Dominik Kuckeburg <[email protected]>
Co-authored-by: nicosvv <[email protected]>
Co-authored-by: MoPhliFra <[email protected]>
@D3vZro D3vZro added this to the Iteration 4 milestone Feb 7, 2025
@D3vZro D3vZro linked an issue Feb 7, 2025 that may be closed by this pull request
chore: redesign of Plan Overview Component #12
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kvnstrck Kvnstrck Kvnstrck approved these changes

@Kha1r0 Kha1r0 Kha1r0 approved these changes

@MoPhliFra MoPhliFra Awaiting requested review from MoPhliFra

@nicosvv nicosvv Awaiting requested review from nicosvv

At least 4 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Iteration 4
Development

Successfully merging this pull request may close these issues.

chore: delete old frontend chore: redesign of Plan Overview Component
3 participants
@D3vZro @Kvnstrck @Kha1r0