-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-18571] Collect and log Spark metrics in various method calls #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolfinus
force-pushed
the
feature/DOP-18571
branch
from
August 8, 2024 10:04
0d4d470
to
018fbc2
Compare
dolfinus
force-pushed
the
feature/DOP-18571
branch
from
August 8, 2024 10:10
018fbc2
to
236d550
Compare
7 tasks
dolfinus
force-pushed
the
feature/DOP-18571
branch
from
August 8, 2024 10:57
236d550
to
7f8d77c
Compare
dolfinus
force-pushed
the
feature/DOP-18571
branch
from
August 8, 2024 11:16
7f8d77c
to
28a87cc
Compare
dolfinus
force-pushed
the
feature/DOP-18571
branch
from
August 8, 2024 11:52
28a87cc
to
94ec908
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #303 +/- ##
===========================================
+ Coverage 94.96% 95.36% +0.39%
===========================================
Files 225 225
Lines 8823 8860 +37
Branches 1507 1499 -8
===========================================
+ Hits 8379 8449 +70
+ Misses 312 292 -20
+ Partials 132 119 -13 ☔ View full report in Codecov by Sentry. |
dolfinus
force-pushed
the
feature/DOP-18571
branch
from
August 8, 2024 12:05
94ec908
to
32888f3
Compare
dolfinus
force-pushed
the
feature/DOP-18571
branch
from
August 8, 2024 12:19
32888f3
to
f7e73cb
Compare
dolfinus
force-pushed
the
feature/DOP-18571
branch
from
August 8, 2024 13:21
f7e73cb
to
f353a8c
Compare
dolfinus
force-pushed
the
feature/DOP-18571
branch
from
August 8, 2024 13:23
f353a8c
to
0b9535d
Compare
dolfinus
force-pushed
the
feature/DOP-18571
branch
from
August 9, 2024 11:18
0b9535d
to
489d72d
Compare
maxim-lixakov
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Use
SparkMetricsRecorded
to collect Spark metrics from those methods:DBWriter.run()
FileDFWriter.run()
JDBC.fetch()
,JDBC.execute()
Hive.execute()
And log these metrics. But the only metrics logged in INFO level are JDBC ones, as they are reliable, others are DEBUG only.
Also I've added function to get estimated size of in-memory dataframe using Spark's
SizeEstimator
. This is an approximate metric, but it always present.Few examples:
DBWriter.run
with Hive:DBWriter.run
with Postgres:Postgres.fetch
:Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)