-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOP-18743] Set default jobDescription #304
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolfinus
force-pushed
the
feature/DOP-18743
branch
from
August 8, 2024 16:31
43b7df1
to
f828c84
Compare
dolfinus
force-pushed
the
feature/DOP-18743
branch
from
August 8, 2024 16:32
f828c84
to
5b30fb0
Compare
dolfinus
force-pushed
the
feature/DOP-18743
branch
from
August 8, 2024 16:42
5b30fb0
to
e56136d
Compare
dolfinus
force-pushed
the
feature/DOP-18743
branch
from
August 8, 2024 17:21
e56136d
to
e2c6990
Compare
dolfinus
requested review from
maxim-lixakov and
TiGrib
and removed request for
maxim-lixakov
August 8, 2024 17:26
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #304 +/- ##
===========================================
+ Coverage 95.36% 95.45% +0.09%
===========================================
Files 225 225
Lines 8860 8931 +71
Branches 1499 1516 +17
===========================================
+ Hits 8449 8525 +76
+ Misses 292 287 -5
Partials 119 119 ☔ View full report in Codecov by Sentry. |
dolfinus
force-pushed
the
feature/DOP-18743
branch
from
August 9, 2024 11:26
e2c6990
to
258a6ee
Compare
dolfinus
changed the title
DOP-18743] Set default jobDescription
[DOP-18743] Set default jobDescription
Aug 9, 2024
dolfinus
force-pushed
the
feature/DOP-18743
branch
from
August 9, 2024 12:51
258a6ee
to
a150101
Compare
dolfinus
force-pushed
the
feature/DOP-18743
branch
from
August 9, 2024 14:47
a150101
to
e34d9e5
Compare
maxim-lixakov
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Set jobDescription in any method which interact with Spark in some way. Examples:
This does not work if Spark action was triggered outside of onETL methods, e.g. user called
df.count()
ordf.toPandas()
:It's hard to write tests on this because jobDescription is reset just before method returned some result.
Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)