Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-18743] Set default jobDescription #304

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Aug 8, 2024

Change Summary

Set jobDescription in any method which interact with Spark in some way. Examples:
Снимок экрана_20240808_192304
Снимок экрана_20240808_192326

This does not work if Spark action was triggered outside of onETL methods, e.g. user called df.count() or df.toPandas():
Снимок экрана_20240808_192425

It's hard to write tests on this because jobDescription is reset just before method returned some result.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 97.53086% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.45%. Comparing base (3c25405) to head (e34d9e5).
Report is 57 commits behind head on develop.

Files with missing lines Patch % Lines
...etl/connection/db_connection/mongodb/connection.py 77.77% 1 Missing and 1 partial ⚠️
onetl/connection/file_connection/ftp.py 66.66% 1 Missing ⚠️
onetl/file/file_df_reader/file_df_reader.py 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #304      +/-   ##
===========================================
+ Coverage    95.36%   95.45%   +0.09%     
===========================================
  Files          225      225              
  Lines         8860     8931      +71     
  Branches      1499     1516      +17     
===========================================
+ Hits          8449     8525      +76     
+ Misses         292      287       -5     
  Partials       119      119              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus changed the title DOP-18743] Set default jobDescription [DOP-18743] Set default jobDescription Aug 9, 2024
@dolfinus dolfinus merged commit d210322 into develop Aug 14, 2024
52 checks passed
@dolfinus dolfinus deleted the feature/DOP-18743 branch August 14, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants