Draw Distance Setting #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix mac build
Fix: Free Camera is forever inverted on the Y-Axis, changing the setting does nothing. sm64pc#373
for that sweet Win9x support
BUGFIX: Camera invert sm64pc#373
BUGFIX: Camera bugs when using flying cap with BETTERCAMERA=1 sm64pc#370
fix mac build for exoquant
Fixes controllers which don't check for rumble_strength and have constant rumble from rumbling even when set to 0 in the config.
Bugfix for NODRAWDISTANCE
Check for zero rumble setting before allowing rumble
it's more to deal with the mouse not working I suppose
Fix Yoshi dialog error that has bothered me for 24 years.
The precision of ray casting was too low previously, causing the collision checks to skip right past a wall sometimes. There was also nothing to prevent the camera from getting too close to a wall horizontally or vertically.
Improve bettercam/puppycam's collision detection and avoidance
BUGFIX: Text Saves aren't saving cannon flags. sm64pc#397
Option Menu Changes
unknown if this has actually caused any issues in EX
Fix by PeachyPeach to stop crashes with Discord Integration when enter later Bowser courses and fights early
apparently this was causing collision issues
The segfault is hit while trying to render bhvCheckerboardElevatorGroup when the player first enters the stage. So here's some background: bhvCheckerboardElevatorGroup is the invisible parent object that defines where the two platforms will rotate around. It has a model, but it's never rendered in game. The entity only exists for a few frames before being removed from the scene. Here's the theory: Since it is only valid for a few frames, I believe the model gets deallocated after removal. Since changing the camera precision makes the camera end up in a slightly different spot, it could be trying to render the object when precision is set to 3 but not to 1. Here's the solution: Adding cur_obj_hide() to the start of bhv_checkerboard_elevator_group_init() prevents the crash fixes sm64pc#437
Prevent crash in vanish cap switch course
thanks to opmox for initial implementation
Also changed applicable files to only import configfile if NODRAWINGDISTANCE is not used (otherwise it's an unused import)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new setting to the Display menu that lets you change the draw distance to anywhere between 0.5x and 5x the original game's draw distance, in 10% increments. This should be useful for weaker devices like a Raspberry Pi that can't handle the NODRAWINGDISTANCE build option. This option does not appear in the menu if NODRAWINGDISTANCE is used.
This was implemented by adding a new variable that is multiplied with every instance where an object's distance to Mario is compared in an "#ifndef NODRAWINGDISTANCE" define. Additionally, all of the original draw distances are divided by 100 since 100 represents a normal draw distance. The end result is the same, but this removes the need for continuous float multiplication where applicable (example: "2400.0f" becomes "24 * configDrawDistance", where configDrawDistance is an integer between 50 and 500, default=100).
Draw Distance Setting.zip
(Note: Ignore the "Files changed" section and instead look at the "Files changed" in the pull request on the main repo. In the PR that you're currently reading, there are many changes that are not part of this patch; they may have been mixed in because I made this using an outdated nightly. The patch does still work on current nightlies, however, and the redundant changes are not included in the patch itself.)