Ports various implementations of particle effects from TGMC #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koshenko
requested changes
Sep 29, 2023
| @@ -0,0 +1,102 @@ | |||
| #define DEBRIS_SPARKS "spark" | |||
There was a problem hiding this comment.
mojave/code/datums/elements/debris.dm, line 1, column [9](https://github.com/Mojave-Sun/mojave-sun-13/actions/runs/6320722331/job/17163641058?pr=2454#step:7:10):
warning: macro redefined: DEBRIS_SPARKS
- code/__DEFINES/particles.dm:1:9: previous definition of DEBRIS_SPARKS
mojave/code/datums/elements/debris.dm, line 2, column 9:
warning: macro redefined: DEBRIS_WOOD
- code/__DEFINES/particles.dm:2:9: previous definition of DEBRIS_WOOD
mojave/code/datums/elements/debris.dm, line 3, column 9:
warning: macro redefined: DEBRIS_ROCK
- code/__DEFINES/particles.dm:3:9: previous definition of DEBRIS_ROCK
mojave/code/datums/elements/debris.dm, line 4, column 9:
warning: macro redefined: DEBRIS_GLASS
- code/__DEFINES/particles.dm:4:9: previous definition of DEBRIS_GLASS
mojave/code/datums/elements/debris.dm, line 5, column 9:
warning: macro redefined: DEBRIS_LEAF
- code/__DEFINES/particles.dm:5:9: previous definition of DEBRIS_LEAF
mojave/code/datums/elements/debris.dm, line 6, column 9:
warning: macro redefined: DEBRIS_SNOW
- code/__DEFINES/particles.dm:6:9: previous definition of DEBRIS_SNOW
Anyway to reasonably clean this up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports the following PRs:
tgstation/TerraGov-Marine-Corps#12752
tgstation/TerraGov-Marine-Corps#13963
tgstation/TerraGov-Marine-Corps#13305
Impact particles are partially implemented, I didn't look through all of the walls and objects in the Mojave folder to add debris element but this should be a good enough base to work off of.
Why It's Good For The Game
Seeing if this visual flair being added will lag the game or nah, looks pretty good.
Changelog
🆑 ma44
add: Ballistic guns now eject smoke when shooting
add: Certain objects and walls will have debris particles when hit by bullets
add: Explosions now have particles
/:cl: