-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature data source kafka topic list + Fix acceptance test #217
base: main
Are you sure you want to change the base?
Feature data source kafka topic list + Fix acceptance test #217
Conversation
Hi @Mongey, |
Thanks for starting on this @dttung2905 "name": {
Type: schema.TypeString,
Required: true,
Description: "The name of the topic.",
},
"partitions": {
Type: schema.TypeInt,
Computed: true,
Description: "Number of partitions.",
},
"replication_factor": {
Type: schema.TypeInt,
Computed: true,
Description: "Number of replicas.",
},
"config": {
Type: schema.TypeMap,
Computed: true,
Description: "A map of string k/v attributes.",
Elem: schema.TypeString,
}, |
Thanks @Mongey for the suggestion. Let me make relevant changes to the MR and update you here |
Hi @Mongey, I have change the returned attributes like you suggested above. Do you mind reviewing it again ? |
Hi @Mongey , just want to revisit this issue whether there is anything I can improve on? |
@Mongey Just to to circle back on this issue for your feedback |
Hi folks, is there any chance to merge this change in near future ? |
Hi @gintek I would love to. Do you know who else could review and merge the MR ? |
e08e5b2
to
a6b3925
Compare
Hi @Mongey, |
Merry Christmas and Happy New Year everyone,
make testacc
step. Example is hereWe use tag
latest
for our docker image (confluentinc/cp-kafka and confluentinc/cp-zookeeper). In the later versionkafka.security.auth.SimpleAclAuthorizer
was replaced bykafka.security.authorizer.AclAuthorizer
which will make kafka throw error and ultimately make all 3 kafka broker goes down