-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress excessive translation #9947
base: content
Are you sure you want to change the base?
Suppress excessive translation #9947
Conversation
Can you show the error it was causing? |
I will describe the reproduction procedure below.
The reason is that at line 411 of zz_games.rpy, it compares the Japanese-translated gamename obtained by renpy.substitute with the prompt that is still in English, causing None to be returned every time. Therefore, this PR suppresses the translation and makes the comparison between two English strings. traceback.txt at crash
|
Thank you, nice catch. I think the fix makes sense if we want to keep relying on game event prompts (which I think we do). |
Additionally, suppressed excessive translation in the label |
I have suppressed excessive translation in the function
mas_games.getGameEVByPrompt
.This excessive translation was causing crashes in translation Submods.