Add Support for Timezones #12
Conversation
they are basically just duplicate info anyways
to compare adoption between schools
| } else { | ||
| currentDate = moment() | ||
| } | ||
| } |
There was a problem hiding this comment.
the updateTime() method is intended for updating the time in general (i.e. for the local time clock). I think it would be better to use moment to convert to and from GMT when storing and retrieving the times
There was a problem hiding this comment.
also, if i'm understanding this correctly, I think this might show the local time at the school instead of the users local time if there is a school selected
| } | ||
|
|
||
|
|
||
| /** | ||
| * @returns the current time as a formatted string | ||
| */ | ||
| function getCurrentTimeString() { return currentDate.toLocaleString('en-US', { hour: 'numeric', minute: 'numeric', second: 'numeric', hour12: !use24HourTime }) } | ||
| function getCurrentTimeString() { return use24HourTime ? currentDate.format("h:mm:ss a") : currentDate.format("H:mm:ss") } |
There was a problem hiding this comment.
I think you have the 12 and 24 hour conditions reversed here
There was a problem hiding this comment.
also, i think AM/PM should be capitalized
|
as mentioned in #10 (comment), this change kinda got lost in the react rewrite, making this pull request no longer applicable to the current React-ified version of the codebase. |
Fixes #10