Cleanup chunkgen & reduce the size and number of oceans #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DensityFunctionBootstrap
…d seems to have missed a couple of wraps, see noodle.json and spaghetti_2d.json)
maityyy
commented
Oct 17, 2024
| context.register(TEMPERATURE, new NoiseParameters(-10, 1.5, 0, 1, 0, 0, 0)); | ||
| context.register(VEGETATION, new NoiseParameters(-8, 1, 1, 0, 0, 0, 0)); | ||
| context.register(CONTINENTS, new NoiseParameters(-9, 1, 1, 2, 2, 2, 1, 1, 1, 1)); | ||
| context.register(EROSION, new NoiseParameters(-9, 1, 1, 0, 0, 1, 1)); // [1, 0, 1, 1] -> [1, 0, 0, 1, 1] |
There was a problem hiding this comment.
I would like to know why this change was made
maityyy
commented
Oct 17, 2024
| private static DensityFunction caves(RegistryEntry<NoiseParameters> cavesLayerNoise, RegistryEntry<NoiseParameters> cavesCheeseNoise, DensityFunction slopedCheese, DensityFunction cavesSpaghetti2d, DensityFunction cavesSpaghettiRoughness, DensityFunction cavesEntrances, DensityFunction cavesPillars) { | ||
| var cavesLayer = mul(constant(4), noise(cavesLayerNoise, 8).square()); | ||
| var cavesCheese = add( | ||
| add(constant(0.27), noise(cavesCheeseNoise, 2, 0.95)).clamp(-1, 1), // 1 -> 2; 0.6666666666666666 -> 0.95 |
There was a problem hiding this comment.
Also, what does it do?
maityyy
commented
Oct 17, 2024
Comment on lines
-133
to
-136
| constant(-0.95), | ||
| mul( | ||
| constant(-0.35), | ||
| noise(noiseParameters.getOrThrow(SPAGHETTI_2D_THICKNESS), 2.0, 1.0) |
There was a problem hiding this comment.
About the cave changes, here's the original code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #74
This PR is a second attempt of #78
Example seed:
-1811070148404453930/execute in aylyth:aylyth run tp @s 0 250 0Old:
New:
