Cascade delete interaction step #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crayolakat
commented
Feb 20, 2024
| @@ -635,14 +638,13 @@ describe("CampaignInteractionStepsForm", () => { | |||
| beforeEach(async () => { | |||
| await setupTest(); | |||
|
|
|||
| const startedCampaign = await createStartedCampaign(); | |||
There was a problem hiding this comment.
Interaction steps of campaigns that have already started are unable to be deleted, so I changed the test to use a campaign that hasn't started yet.
|
This branch was previously approved and merged into the now inactive community-branches-qa branch, and has been successfully running on MoveOn's prod website for months. |
|
codygordon
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes StateVoicesNational#1673
Description
Currently, we are unable to delete interaction steps with children. The solution is to change the foreign key constraint of
parent_interaction_idin theinteraction_steptable to cascade delete.Checklist: