feat: add support for skinned Mesh #4968
Open
Terasology Jenkins.io / SpotBugs
succeeded
Aug 4, 2024 in 0s
27 new issues, 1021 total
| Total | New | Outstanding | Fixed | Trend |
|---|---|---|---|---|
| 1021 | 27 | 994 | 0 | 👎 |
Reference build: Terasology » engine » develop #81
Details
Severity distribution of new issues
| Error | Warning High | Warning Normal | Warning Low |
|---|---|---|---|
| 0 | 0 | 1 | 26 |
Annotations
terasology-jenkins-io / SpotBugs
EI_EXPOSE_REP
LOW:
org.terasology.engine.core.subsystem.headless.assets.HeadlessSkinnedMesh.boneIndex0() may expose internal representation by returning HeadlessSkinnedMesh.boneIndex0
Raw output
<p> Returning a reference to a mutable object value stored in one of the object's fields exposes the internal representation of the object. If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Returning a new copy of the object is better approach in many situations.</p>
terasology-jenkins-io / SpotBugs
EI_EXPOSE_REP
LOW:
org.terasology.engine.core.subsystem.headless.assets.HeadlessSkinnedMesh.boneIndex1() may expose internal representation by returning HeadlessSkinnedMesh.boneIndex1
Raw output
<p> Returning a reference to a mutable object value stored in one of the object's fields exposes the internal representation of the object. If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Returning a new copy of the object is better approach in many situations.</p>
terasology-jenkins-io / SpotBugs
EI_EXPOSE_REP
LOW:
org.terasology.engine.core.subsystem.headless.assets.HeadlessSkinnedMesh.boneIndex2() may expose internal representation by returning HeadlessSkinnedMesh.boneIndex2
Raw output
<p> Returning a reference to a mutable object value stored in one of the object's fields exposes the internal representation of the object. If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Returning a new copy of the object is better approach in many situations.</p>
terasology-jenkins-io / SpotBugs
EI_EXPOSE_REP
LOW:
org.terasology.engine.core.subsystem.headless.assets.HeadlessSkinnedMesh.boneIndex3() may expose internal representation by returning HeadlessSkinnedMesh.boneIndex3
Raw output
<p> Returning a reference to a mutable object value stored in one of the object's fields exposes the internal representation of the object. If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Returning a new copy of the object is better approach in many situations.</p>
terasology-jenkins-io / SpotBugs
EI_EXPOSE_REP
LOW:
org.terasology.engine.core.subsystem.headless.assets.HeadlessSkinnedMesh.bones() may expose internal representation by returning HeadlessSkinnedMesh.bones
Raw output
<p> Returning a reference to a mutable object value stored in one of the object's fields exposes the internal representation of the object. If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Returning a new copy of the object is better approach in many situations.</p>
terasology-jenkins-io / SpotBugs
EI_EXPOSE_REP
LOW:
org.terasology.engine.core.subsystem.headless.assets.HeadlessSkinnedMesh.getAABB() may expose internal representation by returning HeadlessSkinnedMesh.bounds
Raw output
<p> Returning a reference to a mutable object value stored in one of the object's fields exposes the internal representation of the object. If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Returning a new copy of the object is better approach in many situations.</p>
terasology-jenkins-io / SpotBugs
EI_EXPOSE_REP
LOW:
org.terasology.engine.core.subsystem.headless.assets.HeadlessSkinnedMesh.vertices() may expose internal representation by returning HeadlessSkinnedMesh.positions
Raw output
<p> Returning a reference to a mutable object value stored in one of the object's fields exposes the internal representation of the object. If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Returning a new copy of the object is better approach in many situations.</p>
terasology-jenkins-io / SpotBugs
NP_UNWRITTEN_FIELD
NORMAL:
Read of unwritten field bones in org.terasology.engine.core.subsystem.headless.assets.HeadlessSkinnedMesh.doReload(SkinnedMeshData)
Raw output
<p> The program is dereferencing a field that does not seem to ever have a non-null value written to it. Unless the field is initialized via some mechanism not seen by the analysis, dereferencing this value will generate a null pointer exception. </p>
terasology-jenkins-io / SpotBugs
UWF_UNWRITTEN_FIELD
LOW:
Unwritten field: org.terasology.engine.core.subsystem.headless.assets.HeadlessSkinnedMesh.bones
Raw output
<p> This field is never written. All reads of it will return the default value. Check for errors (should it have been initialized?), or remove it if it is useless.</p>
terasology-jenkins-io / SpotBugs
UWF_UNWRITTEN_FIELD
LOW:
Unwritten field: org.terasology.engine.core.subsystem.headless.assets.HeadlessSkinnedMesh.bounds
Raw output
<p> This field is never written. All reads of it will return the default value. Check for errors (should it have been initialized?), or remove it if it is useless.</p>
terasology-jenkins-io / SpotBugs
EI_EXPOSE_REP
LOW:
org.terasology.engine.rendering.assets.mesh.StandardSkinnedMeshData.bones() may expose internal representation by returning StandardSkinnedMeshData.bones
Raw output
<p> Returning a reference to a mutable object value stored in one of the object's fields exposes the internal representation of the object. If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Returning a new copy of the object is better approach in many situations.</p>
terasology-jenkins-io / SpotBugs
DM_DEFAULT_ENCODING
LOW:
Found reliance on default encoding in org.terasology.engine.rendering.gltf.GLTFSkinnedMeshFormat.load(ResourceUrn, List): new java.io.InputStreamReader(InputStream)
Raw output
<p> Found a call to a method which will perform a byte to String (or String to byte) conversion, and will assume that the default platform encoding is suitable. This will cause the application behaviour to vary between platforms. Use an alternative API and specify a charset name or Charset object explicitly. </p>
terasology-jenkins-io / SpotBugs
URF_UNREAD_FIELD
LOW:
Unread field: org.terasology.engine.rendering.gltf.GLTFSkinnedMeshFormat.logger
Raw output
<p> This field is never read. Consider removing it from the class.</p>
terasology-jenkins-io / SpotBugs
PA_PUBLIC_PRIMITIVE_ATTRIBUTE
LOW:
Primitive field org.terasology.engine.rendering.logic.SkinnedMeshComponent.animation is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility.
Raw output
no message found
terasology-jenkins-io / SpotBugs
PA_PUBLIC_PRIMITIVE_ATTRIBUTE
LOW:
Primitive field org.terasology.engine.rendering.logic.SkinnedMeshComponent.boneEntities is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility.
Raw output
no message found
terasology-jenkins-io / SpotBugs
PA_PUBLIC_PRIMITIVE_ATTRIBUTE
LOW:
Primitive field org.terasology.engine.rendering.logic.SkinnedMeshComponent.color is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility.
Raw output
no message found
terasology-jenkins-io / SpotBugs
PA_PUBLIC_PRIMITIVE_ATTRIBUTE
LOW:
Primitive field org.terasology.engine.rendering.logic.SkinnedMeshComponent.localScale is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility.
Raw output
no message found
terasology-jenkins-io / SpotBugs
PA_PUBLIC_PRIMITIVE_ATTRIBUTE
LOW:
Primitive field org.terasology.engine.rendering.logic.SkinnedMeshComponent.material is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility.
Raw output
no message found
terasology-jenkins-io / SpotBugs
PA_PUBLIC_PRIMITIVE_ATTRIBUTE
LOW:
Primitive field org.terasology.engine.rendering.logic.SkinnedMeshComponent.mesh is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility.
Raw output
no message found
terasology-jenkins-io / SpotBugs
PA_PUBLIC_PRIMITIVE_ATTRIBUTE
LOW:
Primitive field org.terasology.engine.rendering.logic.SkinnedMeshComponent.rootBone is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility.
Raw output
no message found
terasology-jenkins-io / SpotBugs
EI_EXPOSE_REP
LOW:
org.terasology.engine.rendering.opengl.OpenGLSkinnedMesh.boneIndex0() may expose internal representation by returning OpenGLSkinnedMesh.boneIndex0
Raw output
<p> Returning a reference to a mutable object value stored in one of the object's fields exposes the internal representation of the object. If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Returning a new copy of the object is better approach in many situations.</p>
terasology-jenkins-io / SpotBugs
EI_EXPOSE_REP
LOW:
org.terasology.engine.rendering.opengl.OpenGLSkinnedMesh.boneIndex1() may expose internal representation by returning OpenGLSkinnedMesh.boneIndex1
Raw output
<p> Returning a reference to a mutable object value stored in one of the object's fields exposes the internal representation of the object. If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Returning a new copy of the object is better approach in many situations.</p>
terasology-jenkins-io / SpotBugs
EI_EXPOSE_REP
LOW:
org.terasology.engine.rendering.opengl.OpenGLSkinnedMesh.boneIndex2() may expose internal representation by returning OpenGLSkinnedMesh.boneIndex2
Raw output
<p> Returning a reference to a mutable object value stored in one of the object's fields exposes the internal representation of the object. If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Returning a new copy of the object is better approach in many situations.</p>
terasology-jenkins-io / SpotBugs
EI_EXPOSE_REP
LOW:
org.terasology.engine.rendering.opengl.OpenGLSkinnedMesh.boneIndex3() may expose internal representation by returning OpenGLSkinnedMesh.boneIndex3
Raw output
<p> Returning a reference to a mutable object value stored in one of the object's fields exposes the internal representation of the object. If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Returning a new copy of the object is better approach in many situations.</p>
terasology-jenkins-io / SpotBugs
EI_EXPOSE_REP
LOW:
org.terasology.engine.rendering.opengl.OpenGLSkinnedMesh.bones() may expose internal representation by returning OpenGLSkinnedMesh.bones
Raw output
<p> Returning a reference to a mutable object value stored in one of the object's fields exposes the internal representation of the object. If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Returning a new copy of the object is better approach in many situations.</p>
Loading