Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "qa: parametrize logger usages" #5180

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Conversation

jdrueckert
Copy link
Member

Reverts #5173

@jdrueckert
Copy link
Member Author

@soloturn slf4j upgrade breaks starting the game

> Task :facades:PC:game
-XX:ConcGCThreads=3 -XX:G1ConcRefinementThreads=13 -XX:GCDrainStackTargetSize=64 -XX:InitialHeapSize=261017728 -XX:MarkStackSize=4194304 -XX:MaxDirectMemorySize=536870912 -XX:MaxHeapSize=805306368 -XX:MinHeapSize=6815736 -XX:+PrintCommandLineFlags -XX:ReservedCodeCacheSize=251658240 -XX:+SegmentedCodeCache -XX:+UseCompressedClassPointers -XX:+UseCompressedOops -XX:+UseG1GC 
SLF4J: No SLF4J providers were found.
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See https://www.slf4j.org/codes.html#noProviders for further details.
SLF4J: Class path contains SLF4J bindings targeting slf4j-api versions 1.7.x or earlier.
SLF4J: Ignoring binding found at [jar:file:/home/jdr/.gradle/caches/modules-2/files-2.1/ch.qos.logback/logback-classic/1.2.12/d4dee19148dccb177a0736eb2027bd195341da78/logback-classic-1.2.12.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See https://www.slf4j.org/codes.html#ignoredBindings for an explanation.
PathManager: Initial code location is /home/jdr/Development/Git/Terasology-iota/engine/build/libs/engine-5.4.0-SNAPSHOT.jar
PathManager: Working directory is /home/jdr/Development/Git/Terasology-iota
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.terasology.engine.core.module.ModuleManager (file:/home/jdr/Development/Git/Terasology-iota/engine/build/libs/engine-5.4.0-SNAPSHOT.jar)
WARNING: Please consider reporting this to the maintainers of org.terasology.engine.core.module.ModuleManager
WARNING: System::setSecurityManager will be removed in a future release
[ALSOFT] (EE) Failed to set real-time priority for thread: Operation not permitted (1)
[ALSOFT] (EE) Failed to set real-time priority for thread: Operation not permitted (1)
X Error of failed request:  GLXBadDrawable
  Major opcode of failed request:  151 (GLX)
  Minor opcode of failed request:  11 (X_GLXSwapBuffers)
  Serial number of failed request:  311
  Current serial number in output stream:  311

> Task :facades:PC:game FAILED

@jdrueckert jdrueckert merged commit 4f42a8f into develop Nov 19, 2023
5 of 6 checks passed
@jdrueckert jdrueckert deleted the revert-5173-qa/logger branch November 19, 2023 21:16
jdrueckert added a commit that referenced this pull request Nov 19, 2023
This was referenced Nov 19, 2023
soloturn pushed a commit that referenced this pull request Nov 25, 2023
soloturn pushed a commit that referenced this pull request Dec 3, 2023
BenjaminAmos pushed a commit that referenced this pull request Dec 6, 2023
* Revert "revert: "qa: parametrize logger usages (#5173)" (#5180)"

This reverts commit 4f42a8f.

* revert upgrade slf4j-2.0

* micrometer 1.9.8 --> 1.9.12

* qa, still use old slf4j, feedback jdrueckert.

gradle does not care about the logger definition in engine-tests, it
uses the one from engine also for the tests. remove it to not confuse.

---------

Co-authored-by: soloturn <[email protected]>
soloturn pushed a commit that referenced this pull request Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant