-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: "qa: parametrize logger usages" #5180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c56c4dd.
@soloturn slf4j upgrade breaks starting the game
|
jdrueckert
added a commit
that referenced
this pull request
Nov 19, 2023
This was referenced Nov 19, 2023
soloturn
pushed a commit
that referenced
this pull request
Nov 25, 2023
soloturn
pushed a commit
that referenced
this pull request
Dec 3, 2023
BenjaminAmos
pushed a commit
that referenced
this pull request
Dec 6, 2023
* Revert "revert: "qa: parametrize logger usages (#5173)" (#5180)" This reverts commit 4f42a8f. * revert upgrade slf4j-2.0 * micrometer 1.9.8 --> 1.9.12 * qa, still use old slf4j, feedback jdrueckert. gradle does not care about the logger definition in engine-tests, it uses the one from engine also for the tests. remove it to not confuse. --------- Co-authored-by: soloturn <[email protected]>
soloturn
pushed a commit
that referenced
this pull request
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5173