Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update readme and merge in blog author guide #209

Merged
merged 8 commits into from
Jun 30, 2023
Merged

Conversation

jdrueckert
Copy link
Member

@jdrueckert jdrueckert commented Apr 10, 2023

  • merge former "getting started", "prerequisites", and "development" sections
  • remove old "contributing section"
  • merge-in blog post authoring information from former docs/blog-documentation.md
  • remove blog post authoring except cover image generation information from former docs/blog-documentation.md
  • rename former docs/blog-documentation.md to docs/blog-cover-generation.md
  • add "communtiy" section with links to social media
  • slightly adjust readme navigation line

@jdrueckert jdrueckert requested a review from Cervator April 10, 2023 16:49
@jdrueckert jdrueckert requested a review from skaldarnar April 21, 2023 16:27
README.md Outdated
Comment on lines 91 to 92
- `title` is your news in a short phrase
(if you're writing a TeraSaturday post, please prefix it with `TeraSaturday #<id>: ` where "\<id\>" is the last TeraSaturday post ID + 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting: The title will define the path under which the blog is being published. For the example above this would be: blog/my-first-terasology-blog/, I think.

Observation: we can easily have a duplication in the title, and it is not obvious that there is a uniqueness constraint on it (nor does it make sense, I think). We should think about using the date in combination with the title, for instance.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note added.
Also created an issue for the uniqueness topic: #213

- `cover` should always be `"./cover.jpg"`
- `description` is a short one or two line summary of your blog post
- `author` is your name / nickname / alias - we recommend using either your GitHub or Discord name
- `date` is the date you want your blog post to be published aka. go online (in ISO form: `YYYY-MM-DD`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this still works the same 🤔

Maybe we should also explain that the folder name <date>-<title> is just a convention and has nothing to do with the date and title from the metadata, although those should match...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, this no longer works - the date is purely cosmetic, it seems 🙄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note on the convention added (further above where the directory name is introduced).
Also created #215 to track re-integrating the scheduling feature.

README.md Outdated
- `posttype` should always be `blog` (without quotation marks)
- `title` is your news in a short phrase
(if you're writing a TeraSaturday post, please prefix it with `TeraSaturday #<id>: ` where "\<id\>" is the last TeraSaturday post ID + 1)
- `cover` should always be `"./cover.jpg"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should state the aspect ratio that should be used for the cover images here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

- `title` is your news in a short phrase
(if you're writing a TeraSaturday post, please prefix it with `TeraSaturday #<id>: ` where "\<id\>" is the last TeraSaturday post ID + 1)
- `cover` should always be `"./cover.jpg"`
- `description` is a short one or two line summary of your blog post
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea where this is used, to be honest o.O I thought it might be used for the preview in the tiles, but I think that just uses the first paragraph or something like that 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created an issue to track this: #214

Copy link
Member

@skaldarnar skaldarnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also describe how to create and name the PR adding the blog post, e.g., a template for the title and which tags to assign and stuff like that.

@jdrueckert
Copy link
Member Author

You could also describe how to create and name the PR adding the blog post, e.g., a template for the title and which tags to assign and stuff like that.

Created an issue to track this: #216

@jdrueckert jdrueckert requested a review from skaldarnar April 30, 2023 12:42
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jdrueckert jdrueckert merged commit 4e9271f into master Jun 30, 2023
@jdrueckert jdrueckert deleted the readme-overhaul branch June 30, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants