Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge upstream-v4.2.8 branch into main #70

Merged
merged 10 commits into from
May 15, 2024
Merged

merge upstream-v4.2.8 branch into main #70

merged 10 commits into from
May 15, 2024

Conversation

toufali
Copy link
Collaborator

@toufali toufali commented May 7, 2024

No description provided.

end

it 'does not match URLs with hashtag-like anchors after a numeral' do
expect(subject.match('https://gcc\.gnu\.org/bugzilla/show_bug.cgi?id=111895#c4')).to be_nil
expect(subject.match('https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111895#c4')).to be_nil

Check failure

Code scanning / CodeQL

Incomplete regular expression for hostnames High test

This regular expression has an unescaped '.' before 'gnu.org/bugzilla/show_bug', so it might match more hosts than expected.
end

it 'does not match URLs with hashtag-like anchors after an empty query parameter' do
expect(subject.match('https://en\.wikipedia\.org/wiki/Ghostbusters_(song)?foo=#Lawsuit')).to be_nil
expect(subject.match('https://en.wikipedia.org/wiki/Ghostbusters_(song)?foo=#Lawsuit')).to be_nil

Check failure

Code scanning / CodeQL

Incomplete regular expression for hostnames High test

This regular expression has an unescaped '.' before 'wikipedia.org/wiki/Ghostbusters_', so it might match more hosts than expected.
@toufali toufali closed this May 8, 2024
@toufali toufali reopened this May 8, 2024
@toufali toufali closed this May 13, 2024
@toufali toufali reopened this May 13, 2024
@toufali toufali merged commit e664d83 into main May 15, 2024
106 of 134 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants